Utilise X-FORWARDED-[FOR|PORT] headers -- Means things work properly when behind a reverse proxy.#397
Closed
DanBUK wants to merge 2 commits intosocketio:masterfrom
DanBUK:master
Closed
Utilise X-FORWARDED-[FOR|PORT] headers -- Means things work properly when behind a reverse proxy.#397DanBUK wants to merge 2 commits intosocketio:masterfrom DanBUK:master
DanBUK wants to merge 2 commits intosocketio:masterfrom
DanBUK:master
Conversation
|
+1, would save me a lot of headache |
Author
|
I just fixed this pull request. I was referencing the wrong object before. |
Contributor
|
x-forwarded-for can be a comma separated list of values, depending on the hops the client made: http://en.wikipedia.org/wiki/X-Forwarded-For#Format Please fix your patch and add tests =] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a simple patch really; but necessary when working behind reverse proxies.